netfilter: nft_nat: return EOPNOTSUPP if type or flags are not supported
authorPablo Neira Ayuso <pablo@netfilter.org>
Fri, 24 Apr 2020 19:55:34 +0000 (21:55 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 27 Apr 2020 22:53:45 +0000 (00:53 +0200)
Instead of EINVAL which should be used for malformed netlink messages.

Fixes: eb31628e37a0 ("netfilter: nf_tables: Add support for IPv6 NAT")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nft_nat.c

index 8b44a4de53294f25f85eb84bd3d5d4aac568d109..bb49a217635eba877cc77ba273658a4bb63d9be6 100644 (file)
@@ -129,7 +129,7 @@ static int nft_nat_init(const struct nft_ctx *ctx, const struct nft_expr *expr,
                priv->type = NF_NAT_MANIP_DST;
                break;
        default:
-               return -EINVAL;
+               return -EOPNOTSUPP;
        }
 
        if (tb[NFTA_NAT_FAMILY] == NULL)
@@ -196,7 +196,7 @@ static int nft_nat_init(const struct nft_ctx *ctx, const struct nft_expr *expr,
        if (tb[NFTA_NAT_FLAGS]) {
                priv->flags = ntohl(nla_get_be32(tb[NFTA_NAT_FLAGS]));
                if (priv->flags & ~NF_NAT_RANGE_MASK)
-                       return -EINVAL;
+                       return -EOPNOTSUPP;
        }
 
        return nf_ct_netns_get(ctx->net, family);