crypto: qat - remove redundant FW image size check
authorJack Xu <jack.xu@intel.com>
Fri, 14 Mar 2025 12:57:53 +0000 (12:57 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 21 Mar 2025 09:33:39 +0000 (17:33 +0800)
The FW image size check is already performed in the function
qat_uclo_check_image() before calling `qat_uclo_map_auth_fw()`.
Therefore, the additional check in `qat_uclo_map_auth_fw()` is redundant
and can be safely removed.

Signed-off-by: Jack Xu <jack.xu@intel.com>
Reviewed-by: Ahsan Atta <ahsan.atta@intel.com>
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/intel/qat/qat_common/qat_uclo.c

index 5ace036addeca8689d8eeab63eca9d51dd914cac..61be6df506847a826d0d82732e2288f89160b82d 100644 (file)
@@ -1418,10 +1418,6 @@ static int qat_uclo_map_auth_fw(struct icp_qat_fw_loader_handle *handle,
        struct icp_qat_simg_ae_mode *simg_ae_mode;
        struct icp_firml_dram_desc img_desc;
 
-       if (size > (ICP_QAT_AE_IMG_OFFSET(handle) + ICP_QAT_CSS_RSA4K_MAX_IMAGE_LEN)) {
-               pr_err("QAT: error, input image size overflow %d\n", size);
-               return -EINVAL;
-       }
        length = (css_hdr->fw_type == CSS_AE_FIRMWARE) ?
                 ICP_QAT_CSS_AE_SIMG_LEN(handle) + simg_offset :
                 size + ICP_QAT_CSS_FWSK_PAD_LEN(handle) + simg_offset;