phy: ti: j721e-wiz: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 26 Aug 2024 10:07:27 +0000 (12:07 +0200)
committerVinod Koul <vkoul@kernel.org>
Fri, 30 Aug 2024 07:56:38 +0000 (13:26 +0530)
Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240826-phy-of-node-scope-v1-11-5b4d82582644@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/ti/phy-j721e-wiz.c

index d0f3ead3fc8056ca85437c346b3a190cf6880986..a6c0c5607ffd7b2bba2b987a42d0d80f8d7db62f 100644 (file)
@@ -1404,7 +1404,7 @@ MODULE_DEVICE_TABLE(of, wiz_id_table);
 
 static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
 {
-       struct device_node *serdes, *subnode;
+       struct device_node *serdes;
 
        serdes = of_get_child_by_name(dev->of_node, "serdes");
        if (!serdes) {
@@ -1412,7 +1412,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
                return -EINVAL;
        }
 
-       for_each_child_of_node(serdes, subnode) {
+       for_each_child_of_node_scoped(serdes, subnode) {
                u32 reg, num_lanes = 1, phy_type = PHY_NONE;
                int ret, i;
 
@@ -1422,7 +1422,6 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
 
                ret = of_property_read_u32(subnode, "reg", &reg);
                if (ret) {
-                       of_node_put(subnode);
                        dev_err(dev,
                                "%s: Reading \"reg\" from \"%s\" failed: %d\n",
                                __func__, subnode->name, ret);