iio: health: afe4403: make use of regmap_clear_bits(), regmap_set_bits()
authorTrevor Gamblin <tgamblin@baylibre.com>
Mon, 17 Jun 2024 13:50:03 +0000 (09:50 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 25 Jun 2024 20:04:46 +0000 (21:04 +0100)
Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Instead of using regmap_update_bits() and passing val = 0, use
regmap_clear_bits().

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-23-88d1338c4cca@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/health/afe4403.c

index 1dbe48dae74eedbd7226f9e46b06240cafebdeb3..52326dc521ac1493f3c486218829e4403de7622a 100644 (file)
@@ -422,9 +422,8 @@ static int afe4403_suspend(struct device *dev)
        struct afe4403_data *afe = iio_priv(indio_dev);
        int ret;
 
-       ret = regmap_update_bits(afe->regmap, AFE440X_CONTROL2,
-                                AFE440X_CONTROL2_PDN_AFE,
-                                AFE440X_CONTROL2_PDN_AFE);
+       ret = regmap_set_bits(afe->regmap, AFE440X_CONTROL2,
+                             AFE440X_CONTROL2_PDN_AFE);
        if (ret)
                return ret;
 
@@ -449,8 +448,8 @@ static int afe4403_resume(struct device *dev)
                return ret;
        }
 
-       ret = regmap_update_bits(afe->regmap, AFE440X_CONTROL2,
-                                AFE440X_CONTROL2_PDN_AFE, 0);
+       ret = regmap_clear_bits(afe->regmap, AFE440X_CONTROL2,
+                               AFE440X_CONTROL2_PDN_AFE);
        if (ret)
                return ret;