KVM: x86: use Intel speculation bugs and features as derived in generic x86 code
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 19 Aug 2019 15:24:07 +0000 (17:24 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 22 Aug 2019 08:09:11 +0000 (10:09 +0200)
Similar to AMD bits, set the Intel bits from the vendor-independent
feature and bug flags, because KVM_GET_SUPPORTED_CPUID does not care
about the vendor and they should be set on AMD processors as well.

Suggested-by: Jim Mattson <jmattson@google.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/cpuid.c
arch/x86/kvm/x86.c

index 43caeb6059b9341901f5e49fdd96c4d750dfd0b8..dd5985eb61b4c3ca617e26d145066cbfb149c217 100644 (file)
@@ -392,6 +392,12 @@ static inline void do_cpuid_7_mask(struct kvm_cpuid_entry2 *entry, int index)
 
                entry->edx &= kvm_cpuid_7_0_edx_x86_features;
                cpuid_mask(&entry->edx, CPUID_7_EDX);
+               if (boot_cpu_has(X86_FEATURE_IBPB) && boot_cpu_has(X86_FEATURE_IBRS))
+                       entry->edx |= F(SPEC_CTRL);
+               if (boot_cpu_has(X86_FEATURE_STIBP))
+                       entry->edx |= F(INTEL_STIBP);
+               if (boot_cpu_has(X86_FEATURE_SSBD))
+                       entry->edx |= F(SPEC_CTRL_SSBD);
                /*
                 * We emulate ARCH_CAPABILITIES in software even
                 * if the host doesn't support it.
index 93b0bd45ac738f6fefea3c7a834758d2e5d91340..6b81c7609d090cbb248c59f6ba4faa5c3e09c19b 100644 (file)
@@ -1254,6 +1254,13 @@ static u64 kvm_get_arch_capabilities(void)
        if (l1tf_vmx_mitigation != VMENTER_L1D_FLUSH_NEVER)
                data |= ARCH_CAP_SKIP_VMENTRY_L1DFLUSH;
 
+       if (!boot_cpu_has_bug(X86_BUG_CPU_MELTDOWN))
+               data |= ARCH_CAP_RDCL_NO;
+       if (!boot_cpu_has_bug(X86_BUG_SPEC_STORE_BYPASS))
+               data |= ARCH_CAP_SSB_NO;
+       if (!boot_cpu_has_bug(X86_BUG_MDS))
+               data |= ARCH_CAP_MDS_NO;
+
        return data;
 }