drm/i915/fb: Add debug spew for misaligned CC plane

We're currently failing to provide any debug output when the
user passes in a misaligned offset for the clear color plane.
Add some debugs prints to make debugging actually possible.

Cc: Sagar Ghuge <sagar.ghuge@intel.com>
Cc: Nanley Chery <nanley.g.chery@intel.com>
Cc: Xi Ruoyao <xry111@xry111.site>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241129065014.8363-3-ville.syrjala@linux.intel.com
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index 223c4218c019d659dc92c43f5a196b6cb948b7dd..e478d412785e3d4f8a644539f4c86a9634080675 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -1694,10 +1694,14 @@ int intel_fill_fb_info(struct drm_i915_private *i915, struct intel_framebuffer *
                 * arithmetic related to alignment and offset calculation.
                 */
                if (is_gen12_ccs_cc_plane(&fb->base, i)) {
-                       if (IS_ALIGNED(fb->base.offsets[i], 64))
-                               continue;
-                       else
+                       if (!IS_ALIGNED(fb->base.offsets[i], 64)) {
+                               drm_dbg_kms(&i915->drm,
+                                           "fb misaligned clear color plane %d offset (0x%x)\n",
+                                           i, fb->base.offsets[i]);
                                return -EINVAL;
+                       }
+
+                       continue;
                }
 
                intel_fb_plane_dims(fb, i, &width, &height);