drm/i915/tv: Filter out >1024 wide modes that would need vertical scaling on gen3
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 12 Nov 2018 17:00:00 +0000 (19:00 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 25 Jan 2019 17:10:15 +0000 (19:10 +0200)
Since gen3 can't handle >1024 wide sources with vertical scaling
let's not advertize such modes in the mode list. Less tempetation
to the user to try out things that won't work.

v2: s/IS_GEN3(dev_priv/IS_GEN(dev_priv, 3)/

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181112170000.27531-17-ville.syrjala@linux.intel.com
Reviewed-by: Imre Deak <imre.deak@intel.com>
drivers/gpu/drm/i915/intel_tv.c

index cb6829bc762f827f232a7034013946968ae640d7..f0b9abda7720d3a5734854e8bafa85a0c361f660 100644 (file)
@@ -1728,6 +1728,7 @@ intel_tv_set_mode_type(struct drm_display_mode *mode,
 static int
 intel_tv_get_modes(struct drm_connector *connector)
 {
+       struct drm_i915_private *dev_priv = to_i915(connector->dev);
        const struct tv_mode *tv_mode = intel_tv_mode_find(connector->state);
        int i, count = 0;
 
@@ -1740,6 +1741,11 @@ intel_tv_get_modes(struct drm_connector *connector)
                    !tv_mode->component_only)
                        continue;
 
+               /* no vertical scaling with wide sources on gen3 */
+               if (IS_GEN(dev_priv, 3) && input->w > 1024 &&
+                   input->h > intel_tv_mode_vdisplay(tv_mode))
+                       continue;
+
                mode = drm_mode_create(connector->dev);
                if (!mode)
                        continue;