libceph, rbd, ceph: "blacklist" -> "blocklist"
authorIlya Dryomov <idryomov@gmail.com>
Mon, 14 Sep 2020 11:39:19 +0000 (13:39 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 12 Oct 2020 13:29:26 +0000 (15:29 +0200)
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Documentation/filesystems/ceph.rst
drivers/block/rbd.c
fs/ceph/addr.c
fs/ceph/file.c
fs/ceph/mds_client.c
fs/ceph/super.c
fs/ceph/super.h
include/linux/ceph/mon_client.h
include/linux/ceph/rados.h
net/ceph/mon_client.c

index 0aa70750df0fe02142cf25a1319ada39093baeb8..7d2ef4e272738d0098611259ea506c48ef81984f 100644 (file)
@@ -163,14 +163,14 @@ Mount Options
         to the default VFS implementation if this option is used.
 
   recover_session=<no|clean>
-       Set auto reconnect mode in the case where the client is blacklisted. The
+       Set auto reconnect mode in the case where the client is blocklisted. The
        available modes are "no" and "clean". The default is "no".
 
        * no: never attempt to reconnect when client detects that it has been
-         blacklisted. Operations will generally fail after being blacklisted.
+         blocklisted. Operations will generally fail after being blocklisted.
 
        * clean: client reconnects to the ceph cluster automatically when it
-         detects that it has been blacklisted. During reconnect, client drops
+         detects that it has been blocklisted. During reconnect, client drops
          dirty data/metadata, invalidates page caches and writable file handles.
          After reconnect, file locks become stale because the MDS loses track
          of them. If an inode contains any stale file locks, read/write on the
index e77eaab5cf23ed1192be0b9bbebb32fb238a136d..bdd33bcf11b157eeeb224d00f5296a7c9c3d9ae7 100644 (file)
@@ -4010,10 +4010,10 @@ static int rbd_try_lock(struct rbd_device *rbd_dev)
                rbd_warn(rbd_dev, "breaking header lock owned by %s%llu",
                         ENTITY_NAME(lockers[0].id.name));
 
-               ret = ceph_monc_blacklist_add(&client->monc,
+               ret = ceph_monc_blocklist_add(&client->monc,
                                              &lockers[0].info.addr);
                if (ret) {
-                       rbd_warn(rbd_dev, "blacklist of %s%llu failed: %d",
+                       rbd_warn(rbd_dev, "blocklist of %s%llu failed: %d",
                                 ENTITY_NAME(lockers[0].id.name), ret);
                        goto out;
                }
@@ -4077,7 +4077,7 @@ static int rbd_try_acquire_lock(struct rbd_device *rbd_dev)
        ret = rbd_try_lock(rbd_dev);
        if (ret < 0) {
                rbd_warn(rbd_dev, "failed to lock header: %d", ret);
-               if (ret == -EBLACKLISTED)
+               if (ret == -EBLOCKLISTED)
                        goto out;
 
                ret = 1; /* request lock anyway */
@@ -4613,7 +4613,7 @@ static void rbd_reregister_watch(struct work_struct *work)
        ret = __rbd_register_watch(rbd_dev);
        if (ret) {
                rbd_warn(rbd_dev, "failed to reregister watch: %d", ret);
-               if (ret != -EBLACKLISTED && ret != -ENOENT) {
+               if (ret != -EBLOCKLISTED && ret != -ENOENT) {
                        queue_delayed_work(rbd_dev->task_wq,
                                           &rbd_dev->watch_dwork,
                                           RBD_RETRY_DELAY);
index b03dbaa9d3451283186a03c2a3ac79fdc4c38b78..7b1f3dad576f2b20996d816a51a06c753368fd93 100644 (file)
@@ -271,8 +271,8 @@ static int ceph_do_readpage(struct file *filp, struct page *page)
        if (err < 0) {
                SetPageError(page);
                ceph_fscache_readpage_cancel(inode, page);
-               if (err == -EBLACKLISTED)
-                       fsc->blacklisted = true;
+               if (err == -EBLOCKLISTED)
+                       fsc->blocklisted = true;
                goto out;
        }
        if (err < PAGE_SIZE)
@@ -312,8 +312,8 @@ static void finish_read(struct ceph_osd_request *req)
        int i;
 
        dout("finish_read %p req %p rc %d bytes %d\n", inode, req, rc, bytes);
-       if (rc == -EBLACKLISTED)
-               ceph_inode_to_client(inode)->blacklisted = true;
+       if (rc == -EBLOCKLISTED)
+               ceph_inode_to_client(inode)->blocklisted = true;
 
        /* unlock all pages, zeroing any data we didn't read */
        osd_data = osd_req_op_extent_osd_data(req, 0);
@@ -737,8 +737,8 @@ static int writepage_nounlock(struct page *page, struct writeback_control *wbc)
                        end_page_writeback(page);
                        return err;
                }
-               if (err == -EBLACKLISTED)
-                       fsc->blacklisted = true;
+               if (err == -EBLOCKLISTED)
+                       fsc->blocklisted = true;
                dout("writepage setting page/mapping error %d %p\n",
                     err, page);
                mapping_set_error(&inode->i_data, err);
@@ -801,8 +801,8 @@ static void writepages_finish(struct ceph_osd_request *req)
        if (rc < 0) {
                mapping_set_error(mapping, rc);
                ceph_set_error_write(ci);
-               if (rc == -EBLACKLISTED)
-                       fsc->blacklisted = true;
+               if (rc == -EBLOCKLISTED)
+                       fsc->blocklisted = true;
        } else {
                ceph_clear_error_write(ci);
        }
@@ -2038,16 +2038,16 @@ static int __ceph_pool_perm_get(struct ceph_inode_info *ci,
        if (err >= 0 || err == -ENOENT)
                have |= POOL_READ;
        else if (err != -EPERM) {
-               if (err == -EBLACKLISTED)
-                       fsc->blacklisted = true;
+               if (err == -EBLOCKLISTED)
+                       fsc->blocklisted = true;
                goto out_unlock;
        }
 
        if (err2 == 0 || err2 == -EEXIST)
                have |= POOL_WRITE;
        else if (err2 != -EPERM) {
-               if (err2 == -EBLACKLISTED)
-                       fsc->blacklisted = true;
+               if (err2 == -EBLOCKLISTED)
+                       fsc->blocklisted = true;
                err = err2;
                goto out_unlock;
        }
index 762a280b703739c38204168f352ec7877918735d..209535d5b8d387389afe25fe8d54ab19fc088749 100644 (file)
@@ -933,8 +933,8 @@ static ssize_t ceph_sync_read(struct kiocb *iocb, struct iov_iter *to,
                ceph_release_page_vector(pages, num_pages);
 
                if (ret < 0) {
-                       if (ret == -EBLACKLISTED)
-                               fsc->blacklisted = true;
+                       if (ret == -EBLOCKLISTED)
+                               fsc->blocklisted = true;
                        break;
                }
 
index 76d8d9495d1d4b4467a8b3b4b23d7a9554e01990..bb2d938a17ac3088272e5c21ee2d3d1b371d77fc 100644 (file)
@@ -3303,7 +3303,7 @@ bad:
 }
 
 static int __decode_session_metadata(void **p, void *end,
-                                    bool *blacklisted)
+                                    bool *blocklisted)
 {
        /* map<string,string> */
        u32 n;
@@ -3318,7 +3318,7 @@ static int __decode_session_metadata(void **p, void *end,
                ceph_decode_32_safe(p, end, len, bad);
                ceph_decode_need(p, end, len, bad);
                if (err_str && strnstr(*p, "blacklisted", len))
-                       *blacklisted = true;
+                       *blocklisted = true;
                *p += len;
        }
        return 0;
@@ -3341,7 +3341,7 @@ static void handle_session(struct ceph_mds_session *session,
        u32 op;
        u64 seq, features = 0;
        int wake = 0;
-       bool blacklisted = false;
+       bool blocklisted = false;
 
        /* decode */
        ceph_decode_need(&p, end, sizeof(*h), bad);
@@ -3354,7 +3354,7 @@ static void handle_session(struct ceph_mds_session *session,
        if (msg_version >= 3) {
                u32 len;
                /* version >= 2, metadata */
-               if (__decode_session_metadata(&p, end, &blacklisted) < 0)
+               if (__decode_session_metadata(&p, end, &blocklisted) < 0)
                        goto bad;
                /* version >= 3, feature bits */
                ceph_decode_32_safe(&p, end, len, bad);
@@ -3445,8 +3445,8 @@ static void handle_session(struct ceph_mds_session *session,
                session->s_state = CEPH_MDS_SESSION_REJECTED;
                cleanup_session_requests(mdsc, session);
                remove_session_caps(session);
-               if (blacklisted)
-                       mdsc->fsc->blacklisted = true;
+               if (blocklisted)
+                       mdsc->fsc->blocklisted = true;
                wake = 2; /* for good measure */
                break;
 
@@ -4367,14 +4367,14 @@ static void maybe_recover_session(struct ceph_mds_client *mdsc)
        if (READ_ONCE(fsc->mount_state) != CEPH_MOUNT_MOUNTED)
                return;
 
-       if (!READ_ONCE(fsc->blacklisted))
+       if (!READ_ONCE(fsc->blocklisted))
                return;
 
        if (fsc->last_auto_reconnect &&
            time_before(jiffies, fsc->last_auto_reconnect + HZ * 60 * 30))
                return;
 
-       pr_info("auto reconnect after blacklisted\n");
+       pr_info("auto reconnect after blocklisted\n");
        fsc->last_auto_reconnect = jiffies;
        ceph_force_reconnect(fsc->sb);
 }
index b3fc9bb61afc50da40206bbff6532e0600fd01d3..2516304379d30dbb319a77375c5f06dc4ef9fa20 100644 (file)
@@ -1241,13 +1241,13 @@ int ceph_force_reconnect(struct super_block *sb)
         * see remove_session_caps_cb() */
        flush_workqueue(fsc->inode_wq);
 
-       /* In case that we were blacklisted. This also reset
+       /* In case that we were blocklisted. This also reset
         * all mon/osd connections */
        ceph_reset_client_addr(fsc->client);
 
        ceph_osdc_clear_abort_err(&fsc->client->osdc);
 
-       fsc->blacklisted = false;
+       fsc->blocklisted = false;
        fsc->mount_state = CEPH_MOUNT_MOUNTED;
 
        if (sb->s_root) {
index 483a52d281cdcfef9f29295e721c36b20bafe530..58269489913053ea34b31f3f5dd4e457e45352f0 100644 (file)
@@ -32,7 +32,7 @@
 #define CEPH_BLOCK_SHIFT   22  /* 4 MB */
 #define CEPH_BLOCK         (1 << CEPH_BLOCK_SHIFT)
 
-#define CEPH_MOUNT_OPT_CLEANRECOVER    (1<<1) /* auto reonnect (clean mode) after blacklisted */
+#define CEPH_MOUNT_OPT_CLEANRECOVER    (1<<1) /* auto reonnect (clean mode) after blocklisted */
 #define CEPH_MOUNT_OPT_DIRSTAT         (1<<4) /* `cat dirname` for stats */
 #define CEPH_MOUNT_OPT_RBYTES          (1<<5) /* dir st_bytes = rbytes */
 #define CEPH_MOUNT_OPT_NOASYNCREADDIR  (1<<7) /* no dcache readdir */
@@ -109,7 +109,7 @@ struct ceph_fs_client {
        unsigned long mount_state;
 
        unsigned long last_auto_reconnect;
-       bool blacklisted;
+       bool blocklisted;
 
        bool have_copy_from2;
 
index ce4ffeb384d79c61e545556c8b13f4f4ce4e5779..b658961156a036d88950d8d7ebc96f146ff4c2b6 100644 (file)
@@ -142,7 +142,7 @@ int ceph_monc_get_version(struct ceph_mon_client *monc, const char *what,
 int ceph_monc_get_version_async(struct ceph_mon_client *monc, const char *what,
                                ceph_monc_callback_t cb, u64 private_data);
 
-int ceph_monc_blacklist_add(struct ceph_mon_client *monc,
+int ceph_monc_blocklist_add(struct ceph_mon_client *monc,
                            struct ceph_entity_addr *client_addr);
 
 extern int ceph_monc_open_session(struct ceph_mon_client *monc);
index 3a518fd0eaad2d1a1f59c319b671e9fc11813d91..43a7a1573b51dce0088f0da59dee344b1de7798e 100644 (file)
@@ -424,7 +424,7 @@ enum {
 };
 
 #define EOLDSNAPC    ERESTART  /* ORDERSNAP flag set; writer has old snapc*/
-#define EBLACKLISTED ESHUTDOWN /* blacklisted */
+#define EBLOCKLISTED ESHUTDOWN /* blocklisted */
 
 /* xattr comparison */
 enum {
index d633a0aeaa5525f8196eaa7881d258da402ba5d2..efcdde47127842af18be42b33cf6a8d212ad5c56 100644 (file)
@@ -896,7 +896,7 @@ bad:
        ceph_msg_dump(msg);
 }
 
-int ceph_monc_blacklist_add(struct ceph_mon_client *monc,
+int ceph_monc_blocklist_add(struct ceph_mon_client *monc,
                            struct ceph_entity_addr *client_addr)
 {
        struct ceph_mon_generic_request *req;
@@ -936,9 +936,9 @@ int ceph_monc_blacklist_add(struct ceph_mon_client *monc,
        ret = wait_generic_request(req);
        if (!ret)
                /*
-                * Make sure we have the osdmap that includes the blacklist
+                * Make sure we have the osdmap that includes the blocklist
                 * entry.  This is needed to ensure that the OSDs pick up the
-                * new blacklist before processing any future requests from
+                * new blocklist before processing any future requests from
                 * this client.
                 */
                ret = ceph_wait_for_latest_osdmap(monc->client, 0);
@@ -947,7 +947,7 @@ out:
        put_generic_request(req);
        return ret;
 }
-EXPORT_SYMBOL(ceph_monc_blacklist_add);
+EXPORT_SYMBOL(ceph_monc_blocklist_add);
 
 /*
  * Resend pending generic requests.