ovl: do not pass overlay dentry to ovl_get_inode()

This is needed for using ovl_get_inode() for decoding file handles
for NFS export.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>

diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index 96587075db114d82788fae7a0a3a7207e834671c..f8f7facb733177d729faf122e2db3dbcb4bf3ff8 100644 (file)
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -643,14 +643,14 @@ static bool ovl_verify_inode(struct inode *inode, struct dentry *lowerdentry,
        return true;
 }
 
-struct inode *ovl_get_inode(struct dentry *dentry, struct dentry *upperdentry,
-                           struct dentry *index)
+struct inode *ovl_get_inode(struct super_block *sb, struct dentry *upperdentry,
+                           struct dentry *lowerdentry, struct dentry *index,
+                           unsigned int numlower)
 {
-       struct dentry *lowerdentry = ovl_dentry_lower(dentry);
        struct inode *realinode = upperdentry ? d_inode(upperdentry) : NULL;
        struct inode *inode;
        /* Already indexed or could be indexed on copy up? */
-       bool indexed = (index || (ovl_indexdir(dentry->d_sb) && !upperdentry));
+       bool indexed = (index || (ovl_indexdir(sb) && !upperdentry));
        struct dentry *origin = indexed ? lowerdentry : NULL;
        bool is_dir;
 
@@ -675,7 +675,7 @@ struct inode *ovl_get_inode(struct dentry *dentry, struct dentry *upperdentry,
                struct inode *key = d_inode(origin ?: upperdentry);
                unsigned int nlink = is_dir ? 1 : realinode->i_nlink;
 
-               inode = iget5_locked(dentry->d_sb, (unsigned long) key,
+               inode = iget5_locked(sb, (unsigned long) key,
                                     ovl_inode_test, ovl_inode_set, key);
                if (!inode)
                        goto out_nomem;
@@ -699,7 +699,7 @@ struct inode *ovl_get_inode(struct dentry *dentry, struct dentry *upperdentry,
                        nlink = ovl_get_nlink(lowerdentry, upperdentry, nlink);
                set_nlink(inode, nlink);
        } else {
-               inode = new_inode(dentry->d_sb);
+               inode = new_inode(sb);
                if (!inode)
                        goto out_nomem;
        }
@@ -711,9 +711,7 @@ struct inode *ovl_get_inode(struct dentry *dentry, struct dentry *upperdentry,
 
        /* Check for non-merge dir that may have whiteouts */
        if (is_dir) {
-               struct ovl_entry *oe = dentry->d_fsdata;
-
-               if (((upperdentry && lowerdentry) || oe->numlower > 1) ||
+               if (((upperdentry && lowerdentry) || numlower > 1) ||
                    ovl_check_origin_xattr(upperdentry ?: lowerdentry)) {
                        ovl_set_flag(OVL_WHITEOUTS, inode);
                }

diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
index 49984c9f368980fbf433bd540d5b9e0200591533..d69ea0a385f6df698edf30ae97d8cb34593895d3 100644 (file)
--- a/fs/overlayfs/namei.c
+++ b/fs/overlayfs/namei.c
@@ -967,7 +967,8 @@ struct dentry *ovl_lookup(struct inode *dir, struct dentry *dentry,
                upperdentry = dget(index);
 
        if (upperdentry || ctr) {
-               inode = ovl_get_inode(dentry, upperdentry, index);
+               inode = ovl_get_inode(dentry->d_sb, upperdentry, origin, index,
+                                     ctr);
                err = PTR_ERR(inode);
                if (IS_ERR(inode))
                        goto out_free_oe;

diff --git a/fs/overlayfs/overlayfs.h b/fs/overlayfs/overlayfs.h
index 4e784f6ff4847a60e6214bc3233685b008ecf0c5..f9fce7a680cdfc06ef2aadaf779dac2a5a9dee89 100644 (file)
--- a/fs/overlayfs/overlayfs.h
+++ b/fs/overlayfs/overlayfs.h
@@ -307,8 +307,9 @@ int ovl_update_time(struct inode *inode, struct timespec *ts, int flags);
 bool ovl_is_private_xattr(const char *name);
 
 struct inode *ovl_new_inode(struct super_block *sb, umode_t mode, dev_t rdev);
-struct inode *ovl_get_inode(struct dentry *dentry, struct dentry *upperdentry,
-                           struct dentry *index);
+struct inode *ovl_get_inode(struct super_block *sb, struct dentry *upperdentry,
+                           struct dentry *lowerdentry, struct dentry *index,
+                           unsigned int numlower);
 static inline void ovl_copyattr(struct inode *from, struct inode *to)
 {
        to->i_uid = from->i_uid;