gpio: xra1403: remove unneeded spi_set_drvdata()
authorAlexandru Ardelean <alexandru.ardelean@analog.com>
Thu, 19 Nov 2020 14:21:04 +0000 (16:21 +0200)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Mon, 30 Nov 2020 16:36:36 +0000 (17:36 +0100)
There is no matching spi_get_drvdata() call in the driver, so there is no
need to do spi_set_drvdata(). This looks like it probably was copied from a
driver that used both spi_set_drvdata() & spi_get_drvdata().

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-xra1403.c

index e2cac12092afa9d06eec52f2e7bf92a8dcac2d34..49c878cfd5c62b83f984fbe9905d24885e1109ad 100644 (file)
@@ -186,15 +186,7 @@ static int xra1403_probe(struct spi_device *spi)
                return ret;
        }
 
-       ret = devm_gpiochip_add_data(&spi->dev, &xra->chip, xra);
-       if (ret < 0) {
-               dev_err(&spi->dev, "Unable to register gpiochip\n");
-               return ret;
-       }
-
-       spi_set_drvdata(spi, xra);
-
-       return 0;
+       return devm_gpiochip_add_data(&spi->dev, &xra->chip, xra);
 }
 
 static const struct spi_device_id xra1403_ids[] = {