crypto: omap-sham - use dev_groups to register attribute groups
authorOvidiu Panait <ovidiu.panait.oss@gmail.com>
Sat, 29 Mar 2025 18:01:22 +0000 (20:01 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Mon, 7 Apr 2025 05:22:26 +0000 (13:22 +0800)
Instead of manually adding attribute groups, set dev_groups pointer to
have the driver core do it.

Signed-off-by: Ovidiu Panait <ovidiu.panait.oss@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/omap-sham.c

index 7021481bf027154d308d742c18c6f1ccdcf2ac0c..56f192cb976dc3df173b5fe32e0512002fca94c6 100644 (file)
@@ -2039,10 +2039,7 @@ static struct attribute *omap_sham_attrs[] = {
        &dev_attr_fallback.attr,
        NULL,
 };
-
-static const struct attribute_group omap_sham_attr_group = {
-       .attrs = omap_sham_attrs,
-};
+ATTRIBUTE_GROUPS(omap_sham);
 
 static int omap_sham_probe(struct platform_device *pdev)
 {
@@ -2158,12 +2155,6 @@ static int omap_sham_probe(struct platform_device *pdev)
                }
        }
 
-       err = sysfs_create_group(&dev->kobj, &omap_sham_attr_group);
-       if (err) {
-               dev_err(dev, "could not create sysfs device attrs\n");
-               goto err_algs;
-       }
-
        return 0;
 
 err_algs:
@@ -2210,8 +2201,6 @@ static void omap_sham_remove(struct platform_device *pdev)
 
        if (!dd->polling_mode)
                dma_release_channel(dd->dma_lch);
-
-       sysfs_remove_group(&dd->dev->kobj, &omap_sham_attr_group);
 }
 
 static struct platform_driver omap_sham_driver = {
@@ -2220,6 +2209,7 @@ static struct platform_driver omap_sham_driver = {
        .driver = {
                .name   = "omap-sham",
                .of_match_table = omap_sham_of_match,
+               .dev_groups = omap_sham_groups,
        },
 };