clk: imx: imx6sx: Allow a different LCDIF1 clock parent
authorFabio Estevam <festevam@denx.de>
Tue, 15 Aug 2023 13:09:23 +0000 (10:09 -0300)
committerAbel Vesa <abel.vesa@linaro.org>
Wed, 4 Oct 2023 12:33:47 +0000 (15:33 +0300)
It is not a good idea to hardcode the LCDIF1 parent inside the
clock driver because some users may want to use a different clock
parent for LCDIF1. One of the reasons could be related to EMI tests.

Remove the harcoded LCDIF1 parent when the LCDIF1 parent is described
via devicetree.

Old dtb's that do not describe the LCDIF1 parent via devicetree will
use the same PLL5 clock as parent to keep the original behavior.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20230815130923.775117-1-festevam@gmail.com
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
drivers/clk/imx/clk-imx6sx.c

index 3f1502933e59fe193cacadfbea5bcd2a95b4c8e8..69f8f6f9ca49b0f117f7b5a98ecd3c4f24200f98 100644 (file)
@@ -121,6 +121,7 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node)
 {
        struct device_node *np;
        void __iomem *base;
+       bool lcdif1_assigned_clk;
 
        clk_hw_data = kzalloc(struct_size(clk_hw_data, hws,
                                          IMX6SX_CLK_CLK_END), GFP_KERNEL);
@@ -498,9 +499,16 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node)
        clk_set_parent(hws[IMX6SX_CLK_EIM_SLOW_SEL]->clk, hws[IMX6SX_CLK_PLL2_PFD2]->clk);
        clk_set_rate(hws[IMX6SX_CLK_EIM_SLOW]->clk, 132000000);
 
-       /* set parent clock for LCDIF1 pixel clock */
-       clk_set_parent(hws[IMX6SX_CLK_LCDIF1_PRE_SEL]->clk, hws[IMX6SX_CLK_PLL5_VIDEO_DIV]->clk);
-       clk_set_parent(hws[IMX6SX_CLK_LCDIF1_SEL]->clk, hws[IMX6SX_CLK_LCDIF1_PODF]->clk);
+       np = of_find_node_by_path("/soc/bus@2200000/spba-bus@2240000/lcdif@2220000");
+       lcdif1_assigned_clk = of_find_property(np, "assigned-clock-parents", NULL);
+
+       /* Set parent clock for LCDIF1 pixel clock if not done via devicetree */
+       if (!lcdif1_assigned_clk) {
+               clk_set_parent(hws[IMX6SX_CLK_LCDIF1_PRE_SEL]->clk,
+                              hws[IMX6SX_CLK_PLL5_VIDEO_DIV]->clk);
+               clk_set_parent(hws[IMX6SX_CLK_LCDIF1_SEL]->clk,
+                              hws[IMX6SX_CLK_LCDIF1_PODF]->clk);
+       }
 
        /* Set the parent clks of PCIe lvds1 and pcie_axi to be pcie ref, axi */
        if (clk_set_parent(hws[IMX6SX_CLK_LVDS1_SEL]->clk, hws[IMX6SX_CLK_PCIE_REF_125M]->clk))