mailbox: omap: Fix mailbox interrupt sharing
authorAndrew Davis <afd@ti.com>
Tue, 11 Jun 2024 17:04:56 +0000 (12:04 -0500)
committerJassi Brar <jassisinghbrar@gmail.com>
Wed, 10 Jul 2024 18:24:55 +0000 (13:24 -0500)
Multiple mailbox users can share one interrupt line. This flag was
mistakenly dropped as part of the FIFO removal. Mark the IRQ as shared.

Reported-by: Beleswar Padhi <b-padhi@ti.com>
Fixes: 3f58c1f4206f ("mailbox: omap: Remove kernel FIFO message queuing")
Signed-off-by: Andrew Davis <afd@ti.com>
Tested-by: Beleswar Padhi <b-padhi@ti.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/omap-mailbox.c

index 46747559b438f885c5addeb2e82a083581b3d90b..7a87424657a158d91b3164114efc5271a247c129 100644 (file)
@@ -230,7 +230,8 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
        int ret = 0;
 
        ret = request_threaded_irq(mbox->irq, NULL, mbox_interrupt,
-                                  IRQF_ONESHOT, mbox->name, mbox);
+                                  IRQF_SHARED | IRQF_ONESHOT, mbox->name,
+                                  mbox);
        if (unlikely(ret)) {
                pr_err("failed to register mailbox interrupt:%d\n", ret);
                return ret;