net: airoha: Do not store hfwd references in airoha_qdma struct
authorLorenzo Bianconi <lorenzo@kernel.org>
Wed, 21 May 2025 07:16:37 +0000 (09:16 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Mon, 26 May 2025 15:32:56 +0000 (17:32 +0200)
Since hfwd descriptor and buffer queues are allocated via
dmam_alloc_coherent() we do not need to store their references
in airoha_qdma struct. This patch does not introduce any logical changes,
just code clean-up.

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250521-airopha-desc-sram-v3-2-a6e9b085b4f0@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/airoha/airoha_eth.c
drivers/net/ethernet/airoha/airoha_eth.h

index 0d627e511266d94e079e8a87d2f812fb14b4ad07..1ed43a5c629fd7a174792d5b50dd2d6fb84d6362 100644 (file)
@@ -1077,17 +1077,13 @@ static int airoha_qdma_init_hfwd_queues(struct airoha_qdma *qdma)
        int size;
 
        size = HW_DSCP_NUM * sizeof(struct airoha_qdma_fwd_desc);
-       qdma->hfwd.desc = dmam_alloc_coherent(eth->dev, size, &dma_addr,
-                                             GFP_KERNEL);
-       if (!qdma->hfwd.desc)
+       if (!dmam_alloc_coherent(eth->dev, size, &dma_addr, GFP_KERNEL))
                return -ENOMEM;
 
        airoha_qdma_wr(qdma, REG_FWD_DSCP_BASE, dma_addr);
 
        size = AIROHA_MAX_PACKET_SIZE * HW_DSCP_NUM;
-       qdma->hfwd.q = dmam_alloc_coherent(eth->dev, size, &dma_addr,
-                                          GFP_KERNEL);
-       if (!qdma->hfwd.q)
+       if (!dmam_alloc_coherent(eth->dev, size, &dma_addr, GFP_KERNEL))
                return -ENOMEM;
 
        airoha_qdma_wr(qdma, REG_FWD_BUF_BASE, dma_addr);
index 531a3c49c1562a986111a1ce1c215c8751c16e09..3e03ae9a5d0d21c0d8d717f2a282ff06ef3b9fbf 100644 (file)
@@ -513,12 +513,6 @@ struct airoha_qdma {
 
        struct airoha_queue q_tx[AIROHA_NUM_TX_RING];
        struct airoha_queue q_rx[AIROHA_NUM_RX_RING];
-
-       /* descriptor and packet buffers for qdma hw forward */
-       struct {
-               void *desc;
-               void *q;
-       } hfwd;
 };
 
 struct airoha_gdm_port {