media: i2c: ov7670: Put ep fwnode after use
authorJacopo Mondi <jacopo+renesas@jmondi.org>
Thu, 31 May 2018 17:35:03 +0000 (13:35 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 24 Jul 2018 19:01:27 +0000 (15:01 -0400)
The just parsed endpoint fwnode has to be put after use.
Currently this is done only in error handling path. Fix that by
putting node unconditionally after use.

Fixes: 01b8444828fc ("media: v4l2: i2c: ov7670: Implement OF mbus configuration")

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/ov7670.c

index 3474ef832c1ef1c3bb247e5c6c8ddb2f51250c70..31bf577b0bd3024b900cfdfc9dbe4b7860b5113c 100644 (file)
@@ -1744,14 +1744,12 @@ static int ov7670_parse_dt(struct device *dev,
                return -EINVAL;
 
        ret = v4l2_fwnode_endpoint_parse(ep, &bus_cfg);
-       if (ret) {
-               fwnode_handle_put(ep);
+       fwnode_handle_put(ep);
+       if (ret)
                return ret;
-       }
 
        if (bus_cfg.bus_type != V4L2_MBUS_PARALLEL) {
                dev_err(dev, "Unsupported media bus type\n");
-               fwnode_handle_put(ep);
                return ret;
        }
        info->mbus_config = bus_cfg.bus.parallel.flags;