mm/damon: simplify the parameter passing for 'check_accesses'
authorKaixu Xia <kaixuxia@tencent.com>
Sat, 27 Aug 2022 09:02:50 +0000 (17:02 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 12 Sep 2022 03:26:04 +0000 (20:26 -0700)
Patch series "mm/damon: Simplify the damon regions access check", v2.

This patchset simplifies the operations when checking the damon regions
accesses.

This patch (of 2):

The parameter 'struct damon_ctx *ctx' isn't used in the functions
__damon_{p,v}a_check_access(), so we can remove it and simplify the
parameter passing.

Link: https://lkml.kernel.org/r/1661590971-20893-1-git-send-email-kaixuxia@tencent.com
Link: https://lkml.kernel.org/r/1661590971-20893-2-git-send-email-kaixuxia@tencent.com
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/paddr.c
mm/damon/vaddr.c

index dc131c6a5403875484baa059eef779254bd0166d..6b0d9e6aa677032f82ecc2c67d8a673a1a32ef55 100644 (file)
@@ -166,8 +166,7 @@ out:
        return result.accessed;
 }
 
-static void __damon_pa_check_access(struct damon_ctx *ctx,
-                                   struct damon_region *r)
+static void __damon_pa_check_access(struct damon_region *r)
 {
        static unsigned long last_addr;
        static unsigned long last_page_sz = PAGE_SIZE;
@@ -196,7 +195,7 @@ static unsigned int damon_pa_check_accesses(struct damon_ctx *ctx)
 
        damon_for_each_target(t, ctx) {
                damon_for_each_region(r, t) {
-                       __damon_pa_check_access(ctx, r);
+                       __damon_pa_check_access(r);
                        max_nr_accesses = max(r->nr_accesses, max_nr_accesses);
                }
        }
index cc04d467ba23db9abb9344443975ca80ace473ba..34a72f5e13f5fd313bd0d95613f4bf4285f5de9a 100644 (file)
@@ -542,8 +542,8 @@ static bool damon_va_young(struct mm_struct *mm, unsigned long addr,
  * mm  'mm_struct' for the given virtual address space
  * r   the region to be checked
  */
-static void __damon_va_check_access(struct damon_ctx *ctx,
-                              struct mm_struct *mm, struct damon_region *r)
+static void __damon_va_check_access(struct mm_struct *mm,
+                               struct damon_region *r)
 {
        static struct mm_struct *last_mm;
        static unsigned long last_addr;
@@ -578,7 +578,7 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx)
                if (!mm)
                        continue;
                damon_for_each_region(r, t) {
-                       __damon_va_check_access(ctx, mm, r);
+                       __damon_va_check_access(mm, r);
                        max_nr_accesses = max(r->nr_accesses, max_nr_accesses);
                }
                mmput(mm);