Input: libps2 - mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 7 May 2019 19:27:21 +0000 (12:27 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 7 May 2019 21:13:04 +0000 (14:13 -0700)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/input/serio/libps2.c: In function ‘ps2_handle_ack’:
drivers/input/serio/libps2.c:407:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (ps2dev->flags & PS2_FLAG_NAK) {
      ^
drivers/input/serio/libps2.c:417:2: note: here
  case 0x00:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/serio/libps2.c

index e6a07e68d1ff69d0ae16ac9d862c8816eb39cc05..22b8e05aa36ca5cc4cfaf2579931f0c841c05a97 100644 (file)
@@ -409,6 +409,7 @@ bool ps2_handle_ack(struct ps2dev *ps2dev, u8 data)
                        ps2dev->nak = PS2_RET_ERR;
                        break;
                }
+               /* Fall through */
 
        /*
         * Workaround for mice which don't ACK the Get ID command.