drm/amd/display: Fix Werror when building
authorWayne Lin <Wayne.Lin@amd.com>
Fri, 8 Oct 2021 07:08:37 +0000 (15:08 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 8 Oct 2021 17:20:14 +0000 (13:20 -0400)
[Why & How]
Got Werror when building with Clang-13:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:195:2:
error: variable 'ts' is used uninitialized whenever switch default is
taken [-Werror,-Wsometimes-uninitialized]

        default:

        ^~~~~~~

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:200:9:
note: uninitialized use occurs here

        return ts;

               ^~

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:180:2:
note: variable 'ts' is declared here

        enum dpia_set_config_ts ts;

        ^

1 error generated.

Fix it.

Reported-by: Mike Lothian <mike@fireburn.co.uk>
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c

index 8387767ec1b3577137f7b7574af00ffb886069ab..8971d7af8113278aac4219ea2c72ed04fe5f2ddf 100644 (file)
@@ -193,6 +193,7 @@ static enum dpia_set_config_ts convert_trng_ptn_to_trng_stg(enum dc_dp_training_
                ts = DPIA_TS_TPS4;
                break;
        default:
+               ts = DPIA_TS_DPRX_DONE;
                ASSERT(false); /* TPS not supported by helper function. */
                break;
        }