drm/i915/dsi: Combine checks in mipi_exec_gpio()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 3 Nov 2023 20:18:30 +0000 (22:18 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 22 Nov 2023 17:13:02 +0000 (19:13 +0200)
For a couple of cases the branches call the same bxt_gpio_set_value().
As Ville suggested they can be combined by dropping the DISPLAY_VER()
check from Gen 11 to Gen 9. Do it that way.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231103201831.1037416-16-andriy.shevchenko@linux.intel.com
drivers/gpu/drm/i915/display/intel_dsi_vbt.c

index 9c6946ccb193e1f8213afd42d84d231578a25f03..275d0218394c17b7fc279e0622f4087d6a96b747 100644 (file)
@@ -420,14 +420,12 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 
        if (native)
                icl_native_gpio_set_value(i915, gpio_number, value);
-       else if (DISPLAY_VER(i915) >= 11)
+       else if (DISPLAY_VER(i915) >= 9)
                bxt_gpio_set_value(connector, gpio_index, value);
        else if (IS_VALLEYVIEW(i915))
                vlv_gpio_set_value(connector, gpio_source, gpio_number, value);
        else if (IS_CHERRYVIEW(i915))
                chv_gpio_set_value(connector, gpio_source, gpio_number, value);
-       else
-               bxt_gpio_set_value(connector, gpio_index, value);
 
        return data + size;
 }