arm, smp: Remove trace_.*_rcuidle() usage
authorPeter Zijlstra <peterz@infradead.org>
Thu, 12 Jan 2023 19:43:37 +0000 (20:43 +0100)
committerIngo Molnar <mingo@kernel.org>
Fri, 13 Jan 2023 10:48:15 +0000 (11:48 +0100)
None of these functions should ever be ran with RCU disabled anymore.

Specifically, do_handle_IPI() is only called from handle_IPI() which
explicitly does irq_enter()/irq_exit() which ensures RCU is watching.

The problem with smp_cross_call() was, per commit description:

   7c64cc0531fa ("arm: Use _rcuidle for smp_cross_call() tracepoints")

... that cpuidle_enter_state_coupled() already had RCU disabled, but that's
long been fixed by commit:

  1098582a0f6c ("sched,idle,rcu: Push rcu_idle deeper into the idle path")

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Tony Lindgren <tony@atomide.com>
Tested-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20230112195540.743432118@infradead.org
arch/arm/kernel/smp.c

index 36e6efad89f309076ef124f6ef139483ea6cccb1..0b8c25763adc3810fcfa99465a97718be6e7f7e7 100644 (file)
@@ -638,7 +638,7 @@ static void do_handle_IPI(int ipinr)
        unsigned int cpu = smp_processor_id();
 
        if ((unsigned)ipinr < NR_IPI)
-               trace_ipi_entry_rcuidle(ipi_types[ipinr]);
+               trace_ipi_entry(ipi_types[ipinr]);
 
        switch (ipinr) {
        case IPI_WAKEUP:
@@ -685,7 +685,7 @@ static void do_handle_IPI(int ipinr)
        }
 
        if ((unsigned)ipinr < NR_IPI)
-               trace_ipi_exit_rcuidle(ipi_types[ipinr]);
+               trace_ipi_exit(ipi_types[ipinr]);
 }
 
 /* Legacy version, should go away once all irqchips have been converted */
@@ -708,7 +708,7 @@ static irqreturn_t ipi_handler(int irq, void *data)
 
 static void smp_cross_call(const struct cpumask *target, unsigned int ipinr)
 {
-       trace_ipi_raise_rcuidle(target, ipi_types[ipinr]);
+       trace_ipi_raise(target, ipi_types[ipinr]);
        __ipi_send_mask(ipi_desc[ipinr], target);
 }