staging: r8188eu: remove useless check
authorPavel Skripkin <paskripkin@gmail.com>
Sun, 5 Sep 2021 20:42:18 +0000 (23:42 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Sep 2021 06:49:49 +0000 (08:49 +0200)
smatch says:
usb_intf.c:326 rtw_hw_suspend() warn: variable dereferenced before check 'padapter' (see line 323)
usb_intf.c:387 rtw_hw_resume() warn: variable dereferenced before check 'padapter' (see line 385)

There is only one caller of rtw_hw_suspend() and it does not check
padapter pointer, so let's just omit this check to make smatch happy.

Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Link: https://lore.kernel.org/r/20210905204218.19317-1-paskripkin@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/os_dep/usb_intf.c

index b7129e8b99245e7cf8688b65ff82c1b7899955a7..56a4138a064fedbc65745441b3c551460f609095 100644 (file)
@@ -323,9 +323,6 @@ int rtw_hw_suspend(struct adapter *padapter)
        struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
        struct net_device *pnetdev = padapter->pnetdev;
 
-
-       if (!padapter)
-               goto error_exit;
        if ((!padapter->bup) || (padapter->bDriverStopped) ||
            (padapter->bSurpriseRemoved)) {
                DBG_88E("padapter->bup=%d bDriverStopped=%d bSurpriseRemoved = %d\n",