mei: vsc: Enhance IVSC chipset stability during warm reboot
authorWentong Wu <wentong.wu@intel.com>
Tue, 25 Jun 2024 08:10:43 +0000 (16:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Jul 2024 10:21:39 +0000 (12:21 +0200)
During system shutdown, incorporate reset logic to ensure the IVSC
chipset remains in a valid state. This adjustment guarantees that
the IVSC chipset operates in a known state following a warm reboot.

Fixes: 566f5ca97680 ("mei: Add transport driver for IVSC device")
Cc: stable@vger.kernel.org # for 6.8+
Signed-off-by: Wentong Wu <wentong.wu@intel.com>
Tested-by: Jason Chen <jason.z.chen@intel.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://lore.kernel.org/r/20240625081047.4178494-2-wentong.wu@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/vsc-tp.c

index e6a98dba8a735ec88787d7c8577879b80b323bf7..5f3195636e53719765eb1a2422d1155f82aa982f 100644 (file)
@@ -568,6 +568,19 @@ static void vsc_tp_remove(struct spi_device *spi)
        free_irq(spi->irq, tp);
 }
 
+static void vsc_tp_shutdown(struct spi_device *spi)
+{
+       struct vsc_tp *tp = spi_get_drvdata(spi);
+
+       platform_device_unregister(tp->pdev);
+
+       mutex_destroy(&tp->mutex);
+
+       vsc_tp_reset(tp);
+
+       free_irq(spi->irq, tp);
+}
+
 static const struct acpi_device_id vsc_tp_acpi_ids[] = {
        { "INTC1009" }, /* Raptor Lake */
        { "INTC1058" }, /* Tiger Lake */
@@ -580,6 +593,7 @@ MODULE_DEVICE_TABLE(acpi, vsc_tp_acpi_ids);
 static struct spi_driver vsc_tp_driver = {
        .probe = vsc_tp_probe,
        .remove = vsc_tp_remove,
+       .shutdown = vsc_tp_shutdown,
        .driver = {
                .name = "vsc-tp",
                .acpi_match_table = vsc_tp_acpi_ids,