memory: omap-gpmc: use WARN() instead of BUG() on wrong free
authorKrzysztof Kozlowski <krzk@kernel.org>
Fri, 24 Jul 2020 18:23:20 +0000 (20:23 +0200)
committerKrzysztof Kozlowski <krzk@kernel.org>
Mon, 17 Aug 2020 18:43:41 +0000 (20:43 +0200)
Since driver tracks reserved memory, freeing a non-reserved GPMC should
not be fatal and crash the system.  Printing a warning is friendlier.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200724182328.3348-9-krzk@kernel.org
drivers/memory/omap-gpmc.c

index 2ef2a7a8ed51f75c22bf366864a6e7dcc5d44ec5..76a9c700cbd5e693a4d4fd0935680505cee06720 100644 (file)
@@ -1072,8 +1072,7 @@ void gpmc_cs_free(int cs)
 
        spin_lock(&gpmc_mem_lock);
        if (cs >= gpmc_cs_num || cs < 0 || !gpmc_cs_reserved(cs)) {
-               printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs);
-               BUG();
+               WARN(1, "Trying to free non-reserved GPMC CS%d\n", cs);
                spin_unlock(&gpmc_mem_lock);
                return;
        }