net: sock: do not set sk_cookie in sk_clone_lock()
authorYafang Shao <laoar.shao@gmail.com>
Fri, 18 Jan 2019 05:00:51 +0000 (13:00 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 19 Jan 2019 18:34:59 +0000 (10:34 -0800)
The only call site of sk_clone_lock is in inet_csk_clone_lock,
and sk_cookie will be set there.
So we don't need to set sk_cookie in sk_clone_lock().

Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/sock.c

index b53764ebb9737286ffcf5485bb97d081e7de86b2..900e8a9435f59ca5f11ec73d37cc7226d6467653 100644 (file)
@@ -1752,7 +1752,6 @@ struct sock *sk_clone_lock(const struct sock *sk, const gfp_t priority)
                newsk->sk_err_soft = 0;
                newsk->sk_priority = 0;
                newsk->sk_incoming_cpu = raw_smp_processor_id();
-               atomic64_set(&newsk->sk_cookie, 0);
                if (likely(newsk->sk_net_refcnt))
                        sock_inuse_add(sock_net(newsk), 1);