[media] tc358743: set direction of reset gpio using devm_gpiod_get
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 18 Aug 2015 08:31:09 +0000 (05:31 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 3 Sep 2015 16:18:05 +0000 (13:18 -0300)
Commit 256148246852 ("[media] tc358743: support probe from device tree")
failed to explicitly set the direction of the reset gpio. Use the
optional flag of devm_gpiod_get to make up leeway.

This is also necessary because the flag parameter will become mandatory
soon.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/i2c/tc358743.c

index fe42c9a1cb7877209c5aafcd76bc03c78d509de0..a4efb6e2e7a2c0d0a6d613c585171106ee7f02c9 100644 (file)
@@ -1681,7 +1681,6 @@ static const struct v4l2_ctrl_config tc358743_ctrl_audio_present = {
 #ifdef CONFIG_OF
 static void tc358743_gpio_reset(struct tc358743_state *state)
 {
-       gpiod_set_value(state->reset_gpio, 0);
        usleep_range(5000, 10000);
        gpiod_set_value(state->reset_gpio, 1);
        usleep_range(1000, 2000);
@@ -1783,7 +1782,7 @@ static int tc358743_probe_of(struct tc358743_state *state)
        state->pdata.ths_trailcnt = 0x2;
        state->pdata.hstxvregcnt = 0;
 
-       state->reset_gpio = devm_gpiod_get(dev, "reset");
+       state->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
        if (IS_ERR(state->reset_gpio)) {
                dev_err(dev, "failed to get reset gpio\n");
                ret = PTR_ERR(state->reset_gpio);