jbd2: remove unused transaction->t_private_list
authorKemeng Shi <shikemeng@huaweicloud.com>
Wed, 18 Dec 2024 14:54:13 +0000 (22:54 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 10 Feb 2025 12:48:24 +0000 (07:48 -0500)
After we remove ext4 journal callback, transaction->t_private_list is
not used anymore. Just remove unused transaction->t_private_list.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Link: https://patch.msgid.link/20241218145414.1422946-3-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Documentation/filesystems/journalling.rst
fs/jbd2/transaction.c
include/linux/jbd2.h

index 0254f7d5742993defcf7f0df32dee35489d86d7b..863e93e623f7ef6afa30e752235c7d44775bfffc 100644 (file)
@@ -111,9 +111,7 @@ a callback function when the transaction is finally committed to disk,
 so that you can do some of your own management. You ask the journalling
 layer for calling the callback by simply setting
 ``journal->j_commit_callback`` function pointer and that function is
-called after each transaction commit. You can also use
-``transaction->t_private_list`` for attaching entries to a transaction
-that need processing when the transaction commits.
+called after each transaction commit.
 
 JBD2 also provides a way to block all transaction updates via
 jbd2_journal_lock_updates() /
index 66513c18ca294b5418aeda2a7d598d5bb524d044..9fe17e290c21b4bcc4793bc42204fdb0a0d2ef2b 100644 (file)
@@ -92,7 +92,6 @@ static void jbd2_get_transaction(journal_t *journal,
        atomic_set(&transaction->t_outstanding_revokes, 0);
        atomic_set(&transaction->t_handle_count, 0);
        INIT_LIST_HEAD(&transaction->t_inode_list);
-       INIT_LIST_HEAD(&transaction->t_private_list);
 
        /* Set up the commit timer for the new transaction. */
        journal->j_commit_timer.expires = round_jiffies_up(transaction->t_expires);
index 561025b4f3d91da4c07918d79e0ea1a8d1899f7a..053444f7a1d05f123ea6fedeb771bec52873fcfd 100644 (file)
@@ -700,12 +700,6 @@ struct transaction_s
 
        /* Disk flush needs to be sent to fs partition [no locking] */
        int                     t_need_data_flush;
-
-       /*
-        * For use by the filesystem to store fs-specific data
-        * structures associated with the transaction
-        */
-       struct list_head        t_private_list;
 };
 
 struct transaction_run_stats_s {