nvmet: remove op_flags for passthru commands
authorChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Tue, 10 Nov 2020 02:24:02 +0000 (18:24 -0800)
committerChristoph Hellwig <hch@lst.de>
Tue, 1 Dec 2020 19:36:36 +0000 (20:36 +0100)
For passthru commands setting op_flags has no meaning. Remove the code
that sets the op flags in nvmet_passthru_map_sg().

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/passthru.c

index be8ae59dcb7109090e1f0d049e9ee3189843e44b..1c84dadfb38f239943ca4a5881992a7a3b19e4d6 100644 (file)
@@ -188,21 +188,15 @@ static void nvmet_passthru_req_done(struct request *rq,
 static int nvmet_passthru_map_sg(struct nvmet_req *req, struct request *rq)
 {
        struct scatterlist *sg;
-       int op_flags = 0;
        struct bio *bio;
        int i, ret;
 
        if (req->sg_cnt > BIO_MAX_PAGES)
                return -EINVAL;
 
-       if (req->cmd->common.opcode == nvme_cmd_flush)
-               op_flags = REQ_FUA;
-       else if (nvme_is_write(req->cmd))
-               op_flags = REQ_SYNC | REQ_IDLE;
-
        bio = bio_alloc(GFP_KERNEL, req->sg_cnt);
        bio->bi_end_io = bio_put;
-       bio->bi_opf = req_op(rq) | op_flags;
+       bio->bi_opf = req_op(rq);
 
        for_each_sg(req->sg, sg, req->sg_cnt, i) {
                if (bio_add_pc_page(rq->q, bio, sg_page(sg), sg->length,