media: nxp: Remove redundant dev_err()
authorRuan Jinjie <ruanjinjie@huawei.com>
Thu, 27 Jul 2023 10:21:54 +0000 (10:21 +0000)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 10 Aug 2023 05:58:36 +0000 (07:58 +0200)
There is no need to call the dev_err() function directly to print a custom
message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
drivers/media/platform/nxp/imx8-isi/imx8-isi-pipe.c

index 9512c0a6196674ea9639984e1c120407985848d8..b7a720198ce57ae0e1bdec9f963f8efd141751d1 100644 (file)
@@ -2742,7 +2742,6 @@ static int mxc_jpeg_probe(struct platform_device *pdev)
        dev_info(&pdev->dev, "choose slot %d\n", jpeg->slot_data.slot);
        dec_irq = platform_get_irq(pdev, 0);
        if (dec_irq < 0) {
-               dev_err(&pdev->dev, "Failed to get irq %d\n", dec_irq);
                ret = dec_irq;
                goto err_irq;
        }
index c4454aa1cb34d35a647f3f45dec831ff4a7369d4..65d20e9bae69db31e01d7acd6bdf5897244de06b 100644 (file)
@@ -791,7 +791,6 @@ int mxc_isi_pipe_init(struct mxc_isi_dev *isi, unsigned int id)
 
        irq = platform_get_irq(to_platform_device(isi->dev), id);
        if (irq < 0) {
-               dev_err(pipe->isi->dev, "Failed to get IRQ (%d)\n", irq);
                ret = irq;
                goto error;
        }