mailbox: bcm-pdc: potential NULL dereference in pdc_shutdown()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 4 Aug 2016 05:30:31 +0000 (08:30 +0300)
committerJassi Brar <jaswinder.singh@linaro.org>
Mon, 29 Aug 2016 13:11:15 +0000 (18:41 +0530)
We can't pass NULL pointers to pdc_ring_free() so I moved the check for
NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/bcm-pdc-mailbox.c

index cbe0c1ee4ba9cca5d442cc9e181291e0a42909ce..c56d4d0b23077466e071b95fc8593947112ffa59 100644 (file)
@@ -1191,10 +1191,11 @@ static void pdc_shutdown(struct mbox_chan *chan)
 {
        struct pdc_state *pdcs = chan->con_priv;
 
-       if (pdcs)
-               dev_dbg(&pdcs->pdev->dev,
-                       "Shutdown mailbox channel for PDC %u", pdcs->pdc_idx);
+       if (!pdcs)
+               return;
 
+       dev_dbg(&pdcs->pdev->dev,
+               "Shutdown mailbox channel for PDC %u", pdcs->pdc_idx);
        pdc_ring_free(pdcs);
 }