scsi: qla2xxx: Return -ENOMEM if kzalloc() fails
authorZheyu Ma <zheyuma97@gmail.com>
Mon, 18 Oct 2021 01:56:21 +0000 (01:56 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 19 Oct 2021 03:01:10 +0000 (23:01 -0400)
The driver probing function should return < 0 for failure, otherwise
kernel will treat value > 0 as success.

Link: https://lore.kernel.org/r/1634522181-31166-1-git-send-email-zheyuma97@gmail.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_os.c

index d2e40aaba734de9e47528c1853cd343634fe4f24..836fedcea241bc0eca8ff181f2cfac1ef8ac8514 100644 (file)
@@ -4157,7 +4157,7 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len,
                                        ql_dbg_pci(ql_dbg_init, ha->pdev,
                                            0xe0ee, "%s: failed alloc dsd\n",
                                            __func__);
-                                       return 1;
+                                       return -ENOMEM;
                                }
                                ha->dif_bundle_kallocs++;