net: x25: remove null checks on arrays calling_ae and called_ae
authorColin Ian King <colin.king@canonical.com>
Thu, 8 Sep 2016 07:42:06 +0000 (08:42 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 10 Sep 2016 01:13:30 +0000 (18:13 -0700)
dtefacs.calling_ae and called_ae are both 20 element __u8 arrays and
cannot be null and hence are redundant checks. Remove these.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/x25/af_x25.c

index a750f330b8ddca8e0ea3e5d8eb88e68f6038e149..f83b74d3e2acf733864b6a9ddd0f6b7cd41fa4ef 100644 (file)
@@ -1500,12 +1500,8 @@ out_fac_release:
                        goto out_dtefac_release;
                if (dtefacs.calling_len > X25_MAX_AE_LEN)
                        goto out_dtefac_release;
-               if (dtefacs.calling_ae == NULL)
-                       goto out_dtefac_release;
                if (dtefacs.called_len > X25_MAX_AE_LEN)
                        goto out_dtefac_release;
-               if (dtefacs.called_ae == NULL)
-                       goto out_dtefac_release;
                x25->dte_facilities = dtefacs;
                rc = 0;
 out_dtefac_release: