wifi: rsi: fix restricted __le32 degrades to integer sparse warnings

drivers/net/wireless/rsi/rsi_91x_usb.c:235:27: warning: restricted __le32 degrades to integer
drivers/net/wireless/rsi/rsi_91x_usb.c:236:27: warning: restricted __le32 degrades to integer
drivers/net/wireless/rsi/rsi_91x_usb.c:237:27: warning: restricted __le32 degrades to integer
drivers/net/wireless/rsi/rsi_91x_usb.c:238:27: warning: restricted __le32 degrades to integer
drivers/net/wireless/rsi/rsi_91x_usb.c:244:36: warning: restricted __le32 degrades to integer
drivers/net/wireless/rsi/rsi_91x_usb.c:245:35: warning: restricted __le32 degrades to integer

These cpu_to_le32() are not making sense. With usb_reg_buf we handle the values
byte at a time to make sure usb_reg_buf is in little endian so no need to
convert anything. And usb_control_msg() expects to have the values in native
endian anyway. So just remove these so they are not spamming our logs.

Compile tested only.

Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240130151556.2315951-3-kvalo@kernel.org

diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c
index 10a465686439e0d1f2876f8b4cb8a6176cf18ff5..dccc139cabb2926adccc4b7ca5e964fa7ca7cc21 100644 (file)
--- a/drivers/net/wireless/rsi/rsi_91x_usb.c
+++ b/drivers/net/wireless/rsi/rsi_91x_usb.c
@@ -232,17 +232,17 @@ static int rsi_usb_reg_write(struct usb_device *usbdev,
        if (!usb_reg_buf)
                return status;
 
-       usb_reg_buf[0] = (cpu_to_le32(value) & 0x00ff);
-       usb_reg_buf[1] = (cpu_to_le32(value) & 0xff00) >> 8;
-       usb_reg_buf[2] = (cpu_to_le32(value) & 0x00ff0000) >> 16;
-       usb_reg_buf[3] = (cpu_to_le32(value) & 0xff000000) >> 24;
+       usb_reg_buf[0] = value & 0x00ff;
+       usb_reg_buf[1] = (value & 0xff00) >> 8;
+       usb_reg_buf[2] = (value & 0x00ff0000) >> 16;
+       usb_reg_buf[3] = (value & 0xff000000) >> 24;
 
        status = usb_control_msg(usbdev,
                                 usb_sndctrlpipe(usbdev, 0),
                                 USB_VENDOR_REGISTER_WRITE,
                                 RSI_USB_REQ_OUT,
-                                ((cpu_to_le32(reg) & 0xffff0000) >> 16),
-                                (cpu_to_le32(reg) & 0xffff),
+                                (reg & 0xffff0000) >> 16,
+                                reg & 0xffff,
                                 (void *)usb_reg_buf,
                                 len,
                                 USB_CTRL_SET_TIMEOUT);