media: rockchip: rga: Fix probe rga_parse_dt bugs
authorOndrej Jirman <megi@xff.cz>
Mon, 15 Aug 2022 10:36:22 +0000 (12:36 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Tue, 30 Aug 2022 05:33:10 +0000 (07:33 +0200)
rga_parse_dt is missing a error return, so if some of the resources
return DEFER_PROBE, probe will succeed without these resources.

Signed-off-by: Ondrej Jirman <megi@xff.cz>
Co-developed-by: Jarrah Gosbell <kernel@undef.tools>
Signed-off-by: Jarrah Gosbell <kernel@undef.tools>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/rockchip/rga/rga.c

index 2f8df74ad0fdec71e5372349007a31a9fa369df0..61b25fcf826e92a38a56dfde1449ed6677e033dc 100644 (file)
@@ -816,7 +816,7 @@ static int rga_probe(struct platform_device *pdev)
 
        ret = rga_parse_dt(rga);
        if (ret)
-               dev_err(&pdev->dev, "Unable to parse OF data\n");
+               return dev_err_probe(&pdev->dev, ret, "Unable to parse OF data\n");
 
        pm_runtime_enable(rga->dev);