staging: unisys: visorbus: remove POSTCODEs from bus_create
authorDavid Kershner <david.kershner@unisys.com>
Tue, 18 Apr 2017 20:55:17 +0000 (16:55 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Apr 2017 09:51:20 +0000 (11:51 +0200)
Removed the POSTCODEs from the function bus_create.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorchipset.c

index d1a02d1809d4f5f0ef86ebd3aacc394f93fd140f..6172e249192a8ba74517141f1585eff21dd3ce24 100644 (file)
@@ -577,16 +577,14 @@ bus_create(struct controlvm_message *inmsg)
 
        bus_info = visorbus_get_device_by_id(bus_no, BUS_ROOT_DEVICE, NULL);
        if (bus_info && (bus_info->state.created == 1)) {
-               POSTCODE_LINUX(BUS_CREATE_FAILURE_PC, 0, bus_no,
-                              DIAG_SEVERITY_ERR);
+               dev_err(&chipset_dev->acpi_device->dev,
+                       "failed bus_create: already exists\n");
                err = -EEXIST;
                goto err_respond;
        }
 
        bus_info = kzalloc(sizeof(*bus_info), GFP_KERNEL);
        if (!bus_info) {
-               POSTCODE_LINUX(BUS_CREATE_FAILURE_PC, 0, bus_no,
-                              DIAG_SEVERITY_ERR);
                err = -ENOMEM;
                goto err_respond;
        }
@@ -595,8 +593,6 @@ bus_create(struct controlvm_message *inmsg)
        bus_info->chipset_bus_no = bus_no;
        bus_info->chipset_dev_no = BUS_ROOT_DEVICE;
 
-       POSTCODE_LINUX(BUS_CREATE_ENTRY_PC, 0, bus_no, DIAG_SEVERITY_PRINT);
-
        if (uuid_le_cmp(cmd->create_bus.bus_inst_uuid, spar_siovm_uuid) == 0) {
                err = save_crash_message(inmsg, CRASH_BUS);
                if (err)
@@ -607,9 +603,6 @@ bus_create(struct controlvm_message *inmsg)
                pmsg_hdr = kzalloc(sizeof(*pmsg_hdr),
                                   GFP_KERNEL);
                if (!pmsg_hdr) {
-                       POSTCODE_LINUX(MALLOC_FAILURE_PC, cmd,
-                                      bus_info->chipset_bus_no,
-                                      DIAG_SEVERITY_ERR);
                        err = -ENOMEM;
                        goto err_free_bus_info;
                }
@@ -625,8 +618,6 @@ bus_create(struct controlvm_message *inmsg)
                                           cmd->create_bus.bus_data_type_uuid);
 
        if (!visorchannel) {
-               POSTCODE_LINUX(BUS_CREATE_FAILURE_PC, 0, bus_no,
-                              DIAG_SEVERITY_ERR);
                err = -ENOMEM;
                goto err_free_pending_msg;
        }
@@ -638,7 +629,6 @@ bus_create(struct controlvm_message *inmsg)
        if (err)
                goto err_destroy_channel;
 
-       POSTCODE_LINUX(BUS_CREATE_EXIT_PC, 0, bus_no, DIAG_SEVERITY_PRINT);
        return 0;
 
 err_destroy_channel: