MIPS: Move definitions for 32/64-bit agonstic inline assembler to new file.
authorRalf Baechle <ralf@linux-mips.org>
Fri, 15 Apr 2016 08:25:33 +0000 (10:25 +0200)
committerRalf Baechle <ralf@linux-mips.org>
Mon, 9 May 2016 10:00:05 +0000 (12:00 +0200)
Inspired by Markos Chandras' patch.  I just didn't want do pull bitsops.h
into pgtable.h.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
References: https://patchwork.linux-mips.org/patch/11052/

arch/mips/include/asm/bitops.h
arch/mips/include/asm/llsc.h [new file with mode: 0644]
arch/mips/include/asm/pgtable.h

index ce9666cf14995ce1b713cccce029244ca5ba24b5..fa57cef12a4664acb29cf8780ed864dd52d68b0d 100644 (file)
 #include <asm/byteorder.h>             /* sigh ... */
 #include <asm/compiler.h>
 #include <asm/cpu-features.h>
+#include <asm/llsc.h>
 #include <asm/sgidefs.h>
 #include <asm/war.h>
 
-#if _MIPS_SZLONG == 32
-#define SZLONG_LOG 5
-#define SZLONG_MASK 31UL
-#define __LL           "ll     "
-#define __SC           "sc     "
-#define __INS          "ins    "
-#define __EXT          "ext    "
-#elif _MIPS_SZLONG == 64
-#define SZLONG_LOG 6
-#define SZLONG_MASK 63UL
-#define __LL           "lld    "
-#define __SC           "scd    "
-#define __INS          "dins    "
-#define __EXT          "dext    "
-#endif
-
 /*
  * These are the "slower" versions of the functions and are in bitops.c.
  * These functions call raw_local_irq_{save,restore}().
diff --git a/arch/mips/include/asm/llsc.h b/arch/mips/include/asm/llsc.h
new file mode 100644 (file)
index 0000000..c6d17d1
--- /dev/null
@@ -0,0 +1,28 @@
+/*
+ * This file is subject to the terms and conditions of the GNU General Public
+ * License.  See the file "COPYING" in the main directory of this archive
+ * for more details.
+ *
+ * Macros for 32/64-bit neutral inline assembler
+ */
+
+#ifndef __ASM_LLSC_H
+#define __ASM_LLSC_H
+
+#if _MIPS_SZLONG == 32
+#define SZLONG_LOG 5
+#define SZLONG_MASK 31UL
+#define __LL           "ll     "
+#define __SC           "sc     "
+#define __INS          "ins    "
+#define __EXT          "ext    "
+#elif _MIPS_SZLONG == 64
+#define SZLONG_LOG 6
+#define SZLONG_MASK 63UL
+#define __LL           "lld    "
+#define __SC           "scd    "
+#define __INS          "dins   "
+#define __EXT          "dext   "
+#endif
+
+#endif /* __ASM_LLSC_H  */
index 9a4fe0133ff1c7d82685d426dc1a91b371a972a6..25b1c1c08cbc21ec9a3e10ff10a1567aeff2359b 100644 (file)
@@ -187,23 +187,16 @@ static inline void set_pte(pte_t *ptep, pte_t pteval)
                 * For SMP, multiple CPUs can race, so we need to do
                 * this atomically.
                 */
-#ifdef CONFIG_64BIT
-#define LL_INSN "lld"
-#define SC_INSN "scd"
-#else /* CONFIG_32BIT */
-#define LL_INSN "ll"
-#define SC_INSN "sc"
-#endif
                unsigned long page_global = _PAGE_GLOBAL;
                unsigned long tmp;
 
                __asm__ __volatile__ (
                        "       .set    push\n"
                        "       .set    noreorder\n"
-                       "1:     " LL_INSN "     %[tmp], %[buddy]\n"
+                       "1:     " __LL "        %[tmp], %[buddy]\n"
                        "       bnez    %[tmp], 2f\n"
                        "        or     %[tmp], %[tmp], %[global]\n"
-                       "       " SC_INSN "     %[tmp], %[buddy]\n"
+                       "       " __SC "        %[tmp], %[buddy]\n"
                        "       beqz    %[tmp], 1b\n"
                        "        nop\n"
                        "2:\n"