Input: amimouse - mark driver struct with __refdata to prevent section mismatch
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 30 Apr 2024 18:46:32 +0000 (11:46 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 30 Apr 2024 18:47:23 +0000 (11:47 -0700)
As described in the added code comment, a reference to .exit.text is ok
for drivers registered via module_platform_driver_probe(). Make this
explicit to prevent the following section mismatch warning

WARNING: modpost: drivers/input/mouse/amimouse: section mismatch in reference: amimouse_driver+0x8 (section: .data) -> amimouse_remove (section: .exit.text)

that triggers on an allmodconfig W=1 build.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/2e3783106bf6bd9a7bdeb12b706378fb16316471.1711748999.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/amimouse.c

index cda0c3ff5a288df0840011442442e0995330287a..2fbbaeb76d708284e1512ed89fc5a7806c177f1f 100644 (file)
@@ -132,7 +132,13 @@ static void __exit amimouse_remove(struct platform_device *pdev)
        input_unregister_device(dev);
 }
 
-static struct platform_driver amimouse_driver = {
+/*
+ * amimouse_remove() lives in .exit.text. For drivers registered via
+ * module_platform_driver_probe() this is ok because they cannot get unbound at
+ * runtime. So mark the driver struct with __refdata to prevent modpost
+ * triggering a section mismatch warning.
+ */
+static struct platform_driver amimouse_driver __refdata = {
        .remove_new = __exit_p(amimouse_remove),
        .driver   = {
                .name   = "amiga-mouse",