selftests/cgroup: fix clang warnings: uninitialized fd variable
authorJohn Hubbard <jhubbard@nvidia.com>
Fri, 3 May 2024 03:51:03 +0000 (20:51 -0700)
committerTejun Heo <tj@kernel.org>
Fri, 3 May 2024 19:06:09 +0000 (09:06 -1000)
First of all, in order to build with clang at all, one must first apply
Valentin Obst's build fix for LLVM [1]. Once that is done, then when
building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...clang warns about fd being used uninitialized, in
test_memcg_reclaim()'s error handling path.

Fix this by initializing fd to -1.

[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
Signed-off-by: Tejun Heo <tj@kernel.org>
tools/testing/selftests/cgroup/test_memcontrol.c

index b462416b380612b4d22f4757379e13cd006aa8a1..41ae8047b889579e751129578be04b7c42ab4d07 100644 (file)
@@ -716,7 +716,9 @@ static bool reclaim_until(const char *memcg, long goal)
  */
 static int test_memcg_reclaim(const char *root)
 {
-       int ret = KSFT_FAIL, fd, retries;
+       int ret = KSFT_FAIL;
+       int fd = -1;
+       int retries;
        char *memcg;
        long current, expected_usage;