ALSA: pcm: Make snd_pcm_lib_malloc_pages() debug message say "allocate"
authorChen-Yu Tsai <wenst@chromium.org>
Mon, 21 Apr 2025 08:52:42 +0000 (16:52 +0800)
committerTakashi Iwai <tiwai@suse.de>
Tue, 22 Apr 2025 13:00:24 +0000 (15:00 +0200)
snd_pcm_lib_malloc_pages() is commonly used for allocating buffers during
the hw_params callback, whereas preallocating buffers goes through
preallocate_pcm_pages().

Having the same terminology in the failure debug messages in both
misleads developers.

Change the debug message in snd_pcm_lib_malloc_pages() to use the
term "allocate" to match its intended use.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Link: https://patch.msgid.link/20250421085244.377228-1-wenst@chromium.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_memory.c

index ea3941f8666b2dbc8c555955cb9e6f6f4cae32b7..56725d36825b45edde585a25397174095aa64d26 100644 (file)
@@ -458,7 +458,7 @@ int snd_pcm_lib_malloc_pages(struct snd_pcm_substream *substream, size_t size)
                                   substream->stream,
                                   size, dmab) < 0) {
                        kfree(dmab);
-                       pr_debug("ALSA pcmC%dD%d%c,%d:%s: cannot preallocate for size %zu\n",
+                       pr_debug("ALSA pcmC%dD%d%c,%d:%s: cannot allocate for size %zu\n",
                                 substream->pcm->card->number, substream->pcm->device,
                                 substream->stream ? 'c' : 'p', substream->number,
                                 substream->pcm->name, size);