drm: bridge: adv7511: Enable DRM_BRIDGE_OP_HPD based on HPD interrupt
authorBiju Das <biju.das.jz@bp.renesas.com>
Tue, 19 Apr 2022 14:24:53 +0000 (15:24 +0100)
committerRobert Foss <robert.foss@linaro.org>
Tue, 19 Apr 2022 16:06:46 +0000 (18:06 +0200)
Connector detection using poll method won't work in case of bridge
attached to the encoder with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR, as
the code defaults to HPD.

Enable DRM_BRIDGE_OP_HPD based on HPD interrupt availability, so that
it will fall back to polling, if HPD is not available.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220419142453.48839-1-biju.das.jz@bp.renesas.com
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

index 668dcefbae17aafc527bba8799f6bbb00a474d35..b3f10c54e06435ad1ecc8499972ed52561da6b62 100644 (file)
@@ -1292,8 +1292,10 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
                goto err_unregister_cec;
 
        adv7511->bridge.funcs = &adv7511_bridge_funcs;
-       adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
-                           | DRM_BRIDGE_OP_HPD;
+       adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID;
+       if (adv7511->i2c_main->irq)
+               adv7511->bridge.ops |= DRM_BRIDGE_OP_HPD;
+
        adv7511->bridge.of_node = dev->of_node;
        adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;