spi: cadence-quadspi: fix cleanup of rx_chan on failure paths
authorKhairul Anuar Romli <khairul.anuar.romli@altera.com>
Mon, 30 Jun 2025 09:11:56 +0000 (17:11 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 1 Jul 2025 13:02:26 +0000 (14:02 +0100)
Remove incorrect checks on cqspi->rx_chan that cause driver breakage
during failure cleanup. Ensure proper resource freeing on the success
path when operating in cqspi->use_direct_mode, preventing leaks and
improving stability.

Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/89765a2b94f047ded4f14babaefb7ef92ba07cb2.1751274389.git.khairul.anuar.romli@altera.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence-quadspi.c

index aa1932ba17cb89194d0c3740047c855f6ec316e7..d3c78f59b22cd97e968ad584841512cdb5108e9e 100644 (file)
@@ -1960,11 +1960,6 @@ static int cqspi_probe(struct platform_device *pdev)
 
        pm_runtime_enable(dev);
 
-       if (cqspi->rx_chan) {
-               dma_release_channel(cqspi->rx_chan);
-               goto probe_setup_failed;
-       }
-
        pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT);
        pm_runtime_use_autosuspend(dev);
        pm_runtime_get_noresume(dev);