ALSA: ad1816a: Fix potential NULL pointer deref in snd_card_ad1816a_pnp()
authorThorsten Blum <thorsten.blum@linux.dev>
Thu, 3 Jul 2025 20:06:13 +0000 (22:06 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 4 Jul 2025 07:04:12 +0000 (09:04 +0200)
Use pr_warn() instead of dev_warn() when 'pdev' is NULL to avoid a
potential NULL pointer dereference.

Cc: stable@vger.kernel.org
Fixes: 20869176d7a7 ("ALSA: ad1816a: Use standard print API")
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20250703200616.304309-2-thorsten.blum@linux.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/ad1816a/ad1816a.c

index 99006dc4777e91ce2e3480addc30c402cfc21bfb..5c9e2d41d9005fc58da681fe97af9a10e2a76ccb 100644 (file)
@@ -98,7 +98,7 @@ static int snd_card_ad1816a_pnp(int dev, struct pnp_card_link *card,
        pdev = pnp_request_card_device(card, id->devs[1].id, NULL);
        if (pdev == NULL) {
                mpu_port[dev] = -1;
-               dev_warn(&pdev->dev, "MPU401 device busy, skipping.\n");
+               pr_warn("MPU401 device busy, skipping.\n");
                return 0;
        }