power: supply: rt9467-charger: Remove "usb_type" property write support
authorHans de Goede <hdegoede@redhat.com>
Sat, 31 Aug 2024 14:20:36 +0000 (16:20 +0200)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Tue, 3 Sep 2024 21:20:27 +0000 (23:20 +0200)
The "usb_type" property must be read-only for charger power-supply devices,
see: Documentation/ABI/testing/sysfs-class-power.

But the rt9467 driver allows writing 0/1 to it to disable/enable charging.
Other charger drivers use the "status" property for this and the rt9467
code also allows writing 0/1 to its "status" property and this does
the exact same thing as writing 0/1 to its "usb_type" property.

Drop write support for the "usb_type" property making it readonly to match
the ABI documentation. If userspace wants to disable/enable charging it
can use the "status" property for this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240831142039.28830-4-hdegoede@redhat.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/rt9467-charger.c

index fdfdc83ab045887299c8f0d154e23b9dc734cb9b..f935bd761ac1c015a6cb55467472ba104bf977c1 100644 (file)
@@ -745,8 +745,6 @@ static int rt9467_psy_set_property(struct power_supply *psy,
                                                    RT9467_RANGE_IPREC, val->intval);
        case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:
                return rt9467_psy_set_ieoc(data, val->intval);
-       case POWER_SUPPLY_PROP_USB_TYPE:
-               return regmap_field_write(data->rm_field[F_USBCHGEN], val->intval);
        default:
                return -EINVAL;
        }
@@ -764,7 +762,6 @@ static int rt9467_chg_prop_is_writeable(struct power_supply *psy,
        case POWER_SUPPLY_PROP_INPUT_VOLTAGE_LIMIT:
        case POWER_SUPPLY_PROP_CHARGE_TERM_CURRENT:
        case POWER_SUPPLY_PROP_PRECHARGE_CURRENT:
-       case POWER_SUPPLY_PROP_USB_TYPE:
                return 1;
        default:
                return 0;