ASoC: wm_adsp: Remove unnecessary NULL check before release_firmware()
authorChen Ni <nichen@iscas.ac.cn>
Mon, 7 Apr 2025 06:34:03 +0000 (14:34 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 7 Apr 2025 23:36:15 +0000 (00:36 +0100)
release_firmware() checks for NULL pointers internally.
Remove unneeded NULL check for fmw here.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20250407063403.2772040-1-nichen@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp.c

index 91c8697c29c321176f93aa6316f891c6ec6ea181..ffd826f30e155b516604212ddc77963ab54477f1 100644 (file)
@@ -718,12 +718,10 @@ static void wm_adsp_release_firmware_files(struct wm_adsp *dsp,
                                           const struct firmware *coeff_firmware,
                                           char *coeff_filename)
 {
-       if (wmfw_firmware)
-               release_firmware(wmfw_firmware);
+       release_firmware(wmfw_firmware);
        kfree(wmfw_filename);
 
-       if (coeff_firmware)
-               release_firmware(coeff_firmware);
+       release_firmware(coeff_firmware);
        kfree(coeff_filename);
 }