soundwire: dmi-quirks: remove duplicate initialization
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 11 May 2021 02:50:35 +0000 (10:50 +0800)
committerVinod Koul <vkoul@kernel.org>
Tue, 11 May 2021 12:20:33 +0000 (17:50 +0530)
cppcheck warning:

drivers/soundwire/dmi-quirks.c:85:12: style: Redundant initialization
for 'map'. The initialized value is overwritten before it is
read. [redundantInitialization]
  for (map = dmi_id->driver_data; map->adr; map++) {
           ^
drivers/soundwire/dmi-quirks.c:83:25: note: map is initialized
  struct adr_remap *map = dmi_id->driver_data;
                        ^
drivers/soundwire/dmi-quirks.c:85:12: note: map is overwritten
  for (map = dmi_id->driver_data; map->adr; map++) {
           ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20210511025035.25233-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/dmi-quirks.c

index 82061c1d98356e10060a9d9d5b8a46ba77b8b7f0..5db0a2443a1d5a5c576e9bc13b2c79763a6bd914 100644 (file)
@@ -80,7 +80,7 @@ u64 sdw_dmi_override_adr(struct sdw_bus *bus, u64 addr)
        /* check if any address remap quirk applies */
        dmi_id = dmi_first_match(adr_remap_quirk_table);
        if (dmi_id) {
-               struct adr_remap *map = dmi_id->driver_data;
+               struct adr_remap *map;
 
                for (map = dmi_id->driver_data; map->adr; map++) {
                        if (map->adr == addr) {