RDMA/hns: Delete unnessary parameters in hns_roce_v2_qp_modify()
authorLijun Ou <oulijun@huawei.com>
Mon, 6 Jan 2020 12:21:13 +0000 (20:21 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 7 Jan 2020 20:26:33 +0000 (16:26 -0400)
Current state and new state of qp won't be configured when modifying qp,
so these two redundant parameters should be removed.

Link: https://lore.kernel.org/r/1578313276-29080-5-git-send-email-liweihang@huawei.com
Signed-off-by: Lijun Ou <oulijun@huawei.com>
Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index 45ff44dfabc3bae9c89cf4ec7968e7cc352d0670..9b9ee22b606b2b0b6887ab04b425d03304ce3674 100644 (file)
@@ -3153,8 +3153,6 @@ static int hns_roce_v2_clear_hem(struct hns_roce_dev *hr_dev,
 }
 
 static int hns_roce_v2_qp_modify(struct hns_roce_dev *hr_dev,
-                                enum ib_qp_state cur_state,
-                                enum ib_qp_state new_state,
                                 struct hns_roce_v2_qp_context *context,
                                 struct hns_roce_qp *hr_qp)
 {
@@ -4437,7 +4435,7 @@ static int hns_roce_v2_modify_qp(struct ib_qp *ibqp,
                       V2_QPC_BYTE_60_QP_ST_S, 0);
 
        /* SW pass context to HW */
-       ret = hns_roce_v2_qp_modify(hr_dev, cur_state, new_state, ctx, hr_qp);
+       ret = hns_roce_v2_qp_modify(hr_dev, ctx, hr_qp);
        if (ret) {
                dev_err(dev, "hns_roce_qp_modify failed(%d)\n", ret);
                goto out;