block/rnbd-clt: Remove some arguments from insert_dev_if_not_exists_devpath
authorGuoqing Jiang <guoqing.jiang@gmx.com>
Mon, 19 Apr 2021 07:37:06 +0000 (09:37 +0200)
committerJens Axboe <axboe@kernel.dk>
Tue, 20 Apr 2021 14:59:03 +0000 (08:59 -0600)
Remove 'pathname' and 'sess' since we can dereference it from 'dev'.

Signed-off-by: Guoqing Jiang <guoqing.jiang@gmx.com>
Reviewed-by: Danil Kipnis <danil.kipnis@cloud.ionos.com>
Signed-off-by: Gioh Kim <gi-oh.kim@cloud.ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Link: https://lore.kernel.org/r/20210419073722.15351-4-gi-oh.kim@ionos.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/rnbd/rnbd-clt.c

index 45a4700766524bd552ee84c18655abb5a2b1e922..5a5c8dea38dc91c3691892ab9221d5f20a9b83f9 100644 (file)
@@ -1471,14 +1471,13 @@ static bool exists_devpath(const char *pathname, const char *sessname)
        return found;
 }
 
-static bool insert_dev_if_not_exists_devpath(const char *pathname,
-                                            struct rnbd_clt_session *sess,
-                                            struct rnbd_clt_dev *dev)
+static bool insert_dev_if_not_exists_devpath(struct rnbd_clt_dev *dev)
 {
        bool found;
+       struct rnbd_clt_session *sess = dev->sess;
 
        mutex_lock(&sess_lock);
-       found = __exists_dev(pathname, sess->sessname);
+       found = __exists_dev(dev->pathname, sess->sessname);
        if (!found) {
                mutex_lock(&sess->lock);
                list_add_tail(&dev->list, &sess->devs_list);
@@ -1522,7 +1521,7 @@ struct rnbd_clt_dev *rnbd_clt_map_device(const char *sessname,
                ret = PTR_ERR(dev);
                goto put_sess;
        }
-       if (insert_dev_if_not_exists_devpath(pathname, sess, dev)) {
+       if (insert_dev_if_not_exists_devpath(dev)) {
                ret = -EEXIST;
                goto put_dev;
        }