scsi: imm: Call scsi_done() directly
authorBart Van Assche <bvanassche@acm.org>
Thu, 7 Oct 2021 20:28:34 +0000 (13:28 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:28:47 +0000 (21:28 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-40-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/imm.c

index 943c9102a7eb8e9a71f5c0397a0108f594054499..be8edcff01775ccf1c5ce07e7d5f40b956c23e48 100644 (file)
@@ -769,7 +769,7 @@ static void imm_interrupt(struct work_struct *work)
 
        spin_lock_irqsave(host->host_lock, flags);
        dev->cur_cmd = NULL;
-       cmd->scsi_done(cmd);
+       scsi_done(cmd);
        spin_unlock_irqrestore(host->host_lock, flags);
        return;
 }
@@ -922,7 +922,6 @@ static int imm_queuecommand_lck(struct scsi_cmnd *cmd,
        dev->failed = 0;
        dev->jstart = jiffies;
        dev->cur_cmd = cmd;
-       cmd->scsi_done = done;
        cmd->result = DID_ERROR << 16;  /* default return code */
        cmd->SCp.phase = 0;     /* bus free */