net: ibm: emac: rgmii: use devm for mutex_init
authorRosen Penev <rosenp@gmail.com>
Wed, 30 Oct 2024 20:37:20 +0000 (13:37 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sun, 3 Nov 2024 22:37:42 +0000 (14:37 -0800)
It seems that since inception, this driver never called mutex_destroy in
_remove. Use devm to handle this automatically.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://patch.msgid.link/20241030203727.6039-6-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/emac/rgmii.c

index 7bafe2edfc50354487959a619cd7f22741762e62..9063f0a17e250d7c51e3f8a591a4e2d729c76543 100644 (file)
@@ -219,13 +219,17 @@ static int rgmii_probe(struct platform_device *ofdev)
        struct device_node *np = ofdev->dev.of_node;
        struct rgmii_instance *dev;
        struct resource regs;
+       int err;
 
        dev = devm_kzalloc(&ofdev->dev, sizeof(struct rgmii_instance),
                           GFP_KERNEL);
        if (!dev)
                return -ENOMEM;
 
-       mutex_init(&dev->lock);
+       err = devm_mutex_init(&ofdev->dev, &dev->lock);
+       if (err)
+               return err;
+
        dev->ofdev = ofdev;
 
        if (of_address_to_resource(np, 0, &regs)) {