mx3fb: fix regression with uninitalized fb_info->mm_lock mutex
authorKrzysztof Helt <krzysztof.h1@wp.pl>
Thu, 9 Jul 2009 18:14:10 +0000 (20:14 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 10 Jul 2009 03:44:44 +0000 (20:44 -0700)
Remove call to the mx3fb_set_par() and the mx3fb_blank() before the
register_framebuffer().

This fixes a problem with uninitialized the fb_info->mm_lock mutex
introduced by the commit 537a1bf059f " fbdev: add mutex for fb_mmap
locking"

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/mx3fb.c

index 567fb944bd2ae0a5de08d16bf4142a92cf79823c..f8778cde218327aec8666b2e758c3763fb9e06a3 100644 (file)
@@ -1365,11 +1365,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan)
        init_completion(&mx3fbi->flip_cmpl);
        disable_irq(ichan->eof_irq);
        dev_dbg(mx3fb->dev, "disabling irq %d\n", ichan->eof_irq);
-       ret = mx3fb_set_par(fbi);
-       if (ret < 0)
-               goto esetpar;
-
-       mx3fb_blank(FB_BLANK_UNBLANK, fbi);
 
        dev_info(dev, "registered, using mode %s\n", fb_mode);