net: hns3: VF not request link status when PF support push link status feature

To reduce the processing of unnecessary mailbox command when PF supports
actively push its link status to VFs, VFs stop sending request link
status command in periodic service task in this case.

Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
index 07aa26ba09667b999ea26be7d2ef22ee6547289b..07066c416d42dd26536aa988f046397a0d1000fe 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
@@ -2340,10 +2340,11 @@ static void hclgevf_periodic_service_task(struct hclgevf_dev *hdev)
        if (!(hdev->serv_processed_cnt % HCLGEVF_STATS_TIMER_INTERVAL))
                hclgevf_tqps_update_stats(handle);
 
-       /* request the link status from the PF. PF would be able to tell VF
-        * about such updates in future so we might remove this later
+       /* VF does not need to request link status when this bit is set, because
+        * PF will push its link status to VFs when link status changed.
         */
-       hclgevf_request_link_info(hdev);
+       if (!test_bit(HCLGEVF_STATE_PF_PUSH_LINK_STATUS, &hdev->state))
+               hclgevf_request_link_info(hdev);
 
        hclgevf_update_link_mode(hdev);
 
@@ -2657,6 +2658,7 @@ static int hclgevf_ae_start(struct hnae3_handle *handle)
        struct hclgevf_dev *hdev = hclgevf_ae_get_hdev(handle);
 
        clear_bit(HCLGEVF_STATE_DOWN, &hdev->state);
+       clear_bit(HCLGEVF_STATE_PF_PUSH_LINK_STATUS, &hdev->state);
 
        hclgevf_reset_tqp_stats(handle);
 

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h
index ade6e7f5be5bc260c512dd4ef7505fcd5bc520c4..956095b89a1bd99997763de01e4d325e32f5e906 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h
@@ -152,6 +152,7 @@ enum hclgevf_states {
        HCLGEVF_STATE_LINK_UPDATING,
        HCLGEVF_STATE_PROMISC_CHANGED,
        HCLGEVF_STATE_RST_FAIL,
+       HCLGEVF_STATE_PF_PUSH_LINK_STATUS,
 };
 
 struct hclgevf_mac {

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c
index 5b2dcd97c1078c83ab8d1bfcc7c9f2f82da27f7b..9b17735b9f4ce35a2251ae624cf8631c546c4eb6 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c
@@ -276,6 +276,7 @@ void hclgevf_mbx_async_handler(struct hclgevf_dev *hdev)
        u8 duplex;
        u32 speed;
        u32 tail;
+       u8 flag;
        u8 idx;
 
        /* we can safely clear it now as we are at start of the async message
@@ -300,11 +301,16 @@ void hclgevf_mbx_async_handler(struct hclgevf_dev *hdev)
                        link_status = msg_q[1];
                        memcpy(&speed, &msg_q[2], sizeof(speed));
                        duplex = (u8)msg_q[4];
+                       flag = (u8)msg_q[5];
 
                        /* update upper layer with new link link status */
                        hclgevf_update_link_status(hdev, link_status);
                        hclgevf_update_speed_duplex(hdev, speed, duplex);
 
+                       if (flag & HCLGE_MBX_PUSH_LINK_STATUS_EN)
+                               set_bit(HCLGEVF_STATE_PF_PUSH_LINK_STATUS,
+                                       &hdev->state);
+
                        break;
                case HCLGE_MBX_LINK_STAT_MODE:
                        idx = (u8)msg_q[1];